Fix frozen command_id default causing concurrent execution stdout corruption#757
Merged
Fix frozen command_id default causing concurrent execution stdout corruption#757
Conversation
Ensures execute() generates a fresh UUIDv7 for each invocation (both sync and async), and that explicitly passed command_id values are preserved. Made-with: Cursor
ross-rl
approved these changes
Mar 10, 2026
44301a6 to
f7bfcb0
Compare
mrw-rl
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
executeandexecute_and_await_completion(both sync and async) usedcommand_id: str = str(uuid7())as a default parameter — Python evaluates this once at class definition time, so every call without an explicitcommand_idreused the same frozen UUIDcommand_id, the rage agent creates two executions writing to the same output file (/runloop/commands/{uuid}.stdout), producing garbled/interleaved stdoutNoneand generate a freshuuid7()per call in the method bodyRoot cause chain
command_id→ all concurrent calls share one UUIDcommand_idguard —HashMap::insertsilently overwrites the prior entryFile::createon the same path truncates the existing stdout file while the first process is still writing → interleaved bytesTest plan
command_id=)