Skip to content

Client incompatible with JPMS modules #697

Open

Description

@chrylis

This is a reopen request for #440 and #566, which have not been fixed. Specifically, since you provide classes in the com.sendgrid namespace from multiple jars, it is not possible to use your client from the modulepath.

JPMS went GA four years ago and was available in preview for some time before that, and Java 11 is about to be replaced as the LTS baseline by Java 17. Getting the SendGrid client working with JPMS will not be overly difficult, and it's a blocker for some of your users.

Activity

  1. JenniferMah commented on Aug 24, 2021

    @JenniferMah
    Contributor

    Hi @chrylis
    I've reopened issue #440. Sendgrid-java already supports Java 11. Other than issue #440 and providing classes in the com.sendgrid namespace from multiple jars, are there any other blockers preventing use of JPMS?

  2. chrisjenx commented on Sep 27, 2021

    @chrisjenx

    Error occurred during initialization of boot layer
    java.lang.module.ResolutionException: Modules java.http.client and sendgrid.java export package com.sendgrid to module org.postgresql.jdbc

  3. chrisjenx commented on Sep 27, 2021

    @chrisjenx

    Create a dist actually compiled against JDK 11 🙄

  4. chrisjenx commented on Sep 27, 2021

    @chrisjenx

    Hi @chrylis
    I've reopened issue #440. Sendgrid-java already supports Java 11. Other than issue #440 and providing classes in the com.sendgrid namespace from multiple jars, are there any other blockers preventing use of JPMS?

    Just to clarify, the current jar is incompatible with JDK11+ built applications. Many libs bumped a major version to do this, in your case, 4.x could continue as J8 then a 5.x could target JDK11+.

    See https://github.com/brettwooldridge/HikariCP for example

  5. chrisjenx commented on Nov 2, 2021

    @chrisjenx

    Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions