Skip to content

Upgrade sendgrid/php-http-client - #295

Merged
thinkingserious merged 5 commits into
sendgrid:masterfrom
akeeman:patch-1
Sep 29, 2016
Merged

thinkingserious merged 5 commits into
sendgrid:masterfrom
akeeman:patch-1

Conversation

@akeeman

@akeeman akeeman commented Sep 21, 2016

Copy link
Copy Markdown
Contributor

Version 3.2.0 and above from the sendgrid/php-http-client library use improved autoloading, fixing a problem where \SendGrid\Response cannot be found when using a non-optimized composer installation.
When semantic versioning is applied, it is save to upgrade to newer feature releases.

Version 3.2.0 and above from the sendgrid/php-http-client library use improved autoloading, fixing a problem where \SendGrid\Response cannot be found when using a non-optimized composer installation.
When semantic versioning is applied, it is save to upgrade to newer feature releases.
@akeeman

akeeman commented Sep 21, 2016

Copy link
Copy Markdown
Contributor Author

I sent the cla to dx@sendgrid.com.

@thinkingserious thinkingserious added status: cla signed type: community enhancement feature request not on Twilio's roadmap labels Sep 22, 2016
@thinkingserious

Copy link
Copy Markdown
Contributor

Thanks for the pull request @akeeman!

Do you want to try solving the failed tests or would you like us to take this one over?

@akeeman

akeeman commented Sep 22, 2016 •

Copy link
Copy Markdown
Contributor Author

As a specific version of the php-http-client is used, it works for now to use reflection properties to check the host, request headers and version of the client.
The client should provide getters for these. I have provided a pr there to fix this. Maybe it's wise to check if that one will be accepted first. Winks to @thinkingserious
It would be nice for the php-http-client to use semantic versioning so the latest bugs fixes and features can be used here too without too much hassle. I opened an issue for that here.

@thinkingserious

Copy link
Copy Markdown
Contributor

@akeeman,

I have merged in your PR, could you please update this pull request?

Thanks!

@akeeman

akeeman commented Sep 27, 2016

Copy link
Copy Markdown
Contributor Author

There you go!

You indicated that the php-http-client library should follow semver standards. Therefore I set the php-http-client version back to to "~3.4", instead of "3.4" (note the tilde!).

@thinkingserious
thinkingserious merged commit 1165725 into sendgrid:master Sep 29, 2016
thinkingserious added a commit that referenced this pull request May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: community enhancement feature request not on Twilio's roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants