Skip to content

fix typo in initialize methods - #115

Merged
SendGridDX merged 1 commit into
sendgrid:masterfrom
digeverything:fix-helper-initializations
Apr 6, 2017
Merged

fix typo in initialize methods#115
SendGridDX merged 1 commit into
sendgrid:masterfrom
digeverything:fix-helper-initializations

Conversation

@digeverything

@digeverything digeverything commented Nov 1, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@thinkingserious thinkingserious added type: bug bug in the library status: cla needed status: work in progress Twilio or the community is in the process of implementing labels Nov 8, 2016
@thinkingserious

thinkingserious commented Nov 8, 2016 •
edited by mbernier
Loading

Copy link
Copy Markdown
Contributor

Hello @benjackson84,

Thanks for the PR!

To merge it, I need a signed CLA, could you please do that for us?

With Best Regards,

Elmer

[Removed for duplication. Our automator is ... working!!!]

@digeverything

digeverything commented Nov 21, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@thinkingserious CLA signed and emailed over last week.

@mbernier

mbernier commented Nov 21, 2016

Copy link
Copy Markdown

Hey @benjackson84, sorry about the duplicate email. We recently added and automator to our github repo (see that reply speed!?!!). This thing is new and doesn't have the same list of people who have signed the CLA, so it's asking everyone for the CLA again.

My apologies on this count, the next step is going to be to make it have a small database to solve this problem :)

Thanks!!

mbernier
mbernier approved these changes Nov 21, 2016
View reviewed changes

@mbernier mbernier left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is approved, pending @thinkingserious final glance.

@thinkingserious

thinkingserious commented Nov 29, 2016

Copy link
Copy Markdown
Contributor

@benjackson84,

This is on our backlog to merge. Thanks again for your support!

@SendGridDX
SendGridDX merged commit 0033e1f into sendgrid:master Apr 6, 2017
@thinkingserious

thinkingserious commented Apr 6, 2017

Copy link
Copy Markdown
Contributor

Hello @benjackson84,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

thinkingserious added a commit that referenced this pull request Apr 6, 2017
@thinkingserious
Version Bump v4.1.1: #115 #134: Fix typos in initialize methods
90637b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mbernier mbernier mbernier approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: work in progress Twilio or the community is in the process of implementing type: bug bug in the library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@digeverything @thinkingserious @mbernier @SendGridDX