Skip to content

Specify required ruby version as '>= 2.0' - #157

Merged
thinkingserious merged 1 commit into
sendgrid:masterfrom
tricknotes:require-ruby-2
May 2, 2017
Merged

thinkingserious merged 1 commit into
sendgrid:masterfrom
tricknotes:require-ruby-2

Conversation

@tricknotes

Copy link
Copy Markdown
Contributor

The keyword argument syntax that introduced Ruby 2.0 is landed on master.
Such as https://github.com/sendgrid/sendgrid-ruby/blob/v4.0.8/lib/sendgrid/client.rb#L17.

The keyword argument syntax that introduced Ruby 2.0 is landed on master.
@SendGridDX SendGridDX added the status: code review request requesting a community code review or review from Twilio label Apr 1, 2017
@SendGridDX

Copy link
Copy Markdown

Hello @tricknotes,

Here is why we removed that: #72

Could you please review that PR and let us know your feedback?

Thanks!

Elmer

@thinkingserious

Copy link
Copy Markdown
Contributor

Hello @tricknotes,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@thinkingserious
thinkingserious merged commit 732715a into sendgrid:master May 2, 2017
@tricknotes
tricknotes deleted the require-ruby-2 branch May 3, 2017 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants