Repository navigation
LT-21401: Part 1 - Move FollowLink to Pub/Sub - #921
Conversation
This replaces the easy Mediator.SendMessage() calls that execute immediately. The more difficult Mediator.PostMessage() calls, that execute OnIdle, will be in separate changes. These changes are very similar to the changes that are in commit b886d2e, in the PubSub branch. The changes were done using AI instead of a cherry-pick, mainly to avoid regressing commit 42aad33 (which fixed FollowLink defect LT-20930).
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 7 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on mark-sil).
Src/LexText/Interlinear/InterlinearTextsRecordClerk.cs line 293 at r1 (raw file):
Publisher.Publish(new PublisherParameterObject(EventConstants.FollowLink, new FwLinkArgs("interlinearEdit", CurrentObject.Guid))); } // This is a workable alternative (where link is the one created above), but means this code has to know about the FwXApp class.
Lets delete these comments about things that don't work that we aren't going to be trying.
Render comparison artifactsRender snapshot failures were reported in c3f97bafe90b run 26843916588.1, but the latest run c3f97bafe90b run 26843916588.2 is clean. This comment will be replaced if a future run produces render snapshot failures again. |
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil made 1 comment.
Reviewable status: 6 of 7 files reviewed, all discussions resolved (waiting on jasonleenaylor).
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:
This replaces the easy Mediator.SendMessage() calls that execute immediately. The more difficult Mediator.PostMessage() calls, that execute OnIdle, will be in separate changes.
These changes are very similar to the changes that are in commit b886d2e, in the PubSub branch. The changes were done using AI instead of a cherry-pick, mainly to avoid regressing commit 42aad33 (which fixed FollowLink defect LT-20930).
This change is