Merged
Conversation
Make table.transform() preserve STRICT mode.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
==========================================
- Coverage 95.77% 95.72% -0.06%
==========================================
Files 8 8
Lines 2842 2852 +10
==========================================
+ Hits 2722 2730 +8
- Misses 120 122 +2 ☔ View full report in Codecov by Sentry. |
Owner
|
This looks really great on first glance - design is good, implementation is solid, tests and documentation look great. Looks like a couple of |
Contributor
Author
|
Apologies - I pushed a fix that addresses the mypy failures. |
Owner
|
Also tested this manually like so: sqlite-utils create-table strict.db strictint id integer size integer --strict
sqlite-utils create-table strict.db notstrictint id integer size integer
sqlite-utils install sqlite-utils-shell
sqlite-utils shell strict.db |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
table.transform()preserve STRICT mode.📚 Documentation preview 📚: https://sqlite-utils--604.org.readthedocs.build/en/604/