Skip to content

Incorrectly suggests adding summary attribute to HTML5 document #161

Description

@robfentress

When I have a table in an HTML5 document, HTML_CodeSniffer gives the following suggestion:

If this table is a data table, consider using the summary attribute of the table element to give an overview of this table.

Since HTML5 does not include the summary attribute anymore, I believe this is incorrect advice.

Activity

  1. luketw commented on Apr 27, 2016

    @luketw
    Member

    Hi Rob,

    At the moment HTMLCS doesn't distinguish between HTML4 and HTML5 at the moment, things like this are shown as non-error messages for the time being.

    Seeing HTML5 is a LOT more of a thing now, and now that the limitations to detection are winding down (eg. IE8 is basically dead), I'll be looking to implement a document type detection/setting feature (see #137 for instance) with a bit more priority. Watch this space.

  2. luketw commented on May 9, 2016

    @luketw
    Member

    Hi Rob,

    This change is now in the trunk, and should be in a released version soon I hope.

    Thanks again for your report.

  3. Rudloff commented on Oct 27, 2016

    @Rudloff

    Hello,
    In this in the current release? It still complains about the summary attribute in my HTML5 pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions