[Snyk] Security upgrade alpine from 3.17 to 3.23.2#19
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-ALPINE317-MUSL-8720633 - https://snyk.io/vuln/SNYK-ALPINE317-MUSL-8720633 - https://snyk.io/vuln/SNYK-ALPINE317-OPENSSL-8235199 - https://snyk.io/vuln/SNYK-ALPINE317-OPENSSL-8235199
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @tpsaint, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the security posture of the project by updating the Docker base image. By moving to a newer version of Alpine Linux, it proactively mitigates known vulnerabilities, ensuring the application runs on a more secure foundation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request from Snyk attempts to resolve security vulnerabilities by upgrading the Alpine base image. However, the proposed change is incorrect and incomplete. It modifies a generated Dockerfile directly, which is explicitly forbidden by comments in the file, meaning the change will be lost upon regeneration. Furthermore, it only addresses one of many Dockerfiles that use the vulnerable base image, leaving other parts of the project exposed. The target image version alpine:3.23.2 also appears to be invalid. The correct fix would involve updating the configuration file (versions.json) that is used to generate all Dockerfiles and then re-running the generation script. Due to these issues, this PR should not be merged in its current state.
| # | ||
|
|
||
| FROM alpine:3.17 | ||
| FROM alpine:3.23.2 |
There was a problem hiding this comment.
This change is applied to a generated file, which is explicitly discouraged by the comment header in this file. Any direct edits will be overwritten the next time apply-templates.sh is run, undoing this security fix.
Additionally, this fix is incomplete. Several other Dockerfiles in this repository for different Python versions (3.9, 3.10, 3.11, 3.12, 3.13-rc) also use the vulnerable alpine:3.17 base image and are not updated in this pull request, leaving them vulnerable.
The correct approach is to modify the source that generates these Dockerfiles. The versions.json file should be updated to replace "alpine3.17" with a newer, secure version for all relevant Python versions. Then, apply-templates.sh should be run to regenerate all affected Dockerfiles consistently.
Furthermore, the target version alpine:3.23.2 appears to be invalid and should be replaced with a correct, existing Alpine image tag (for example, a recent version like 3.20).
Due to these critical issues, this change should be reverted and the fix should be applied to the source configuration instead.
Snyk has created this PR to fix 2 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):
3.8/alpine3.17/DockerfileWe recommend upgrading to
alpine:3.23.2, as this image has only 0 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.Vulnerabilities that will be fixed with an upgrade:
SNYK-ALPINE317-MUSL-8720633
SNYK-ALPINE317-MUSL-8720633
SNYK-ALPINE317-OPENSSL-8235199
SNYK-ALPINE317-OPENSSL-8235199
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.