[Snyk] Security upgrade alpine from 3.17 to 3.23.2#21
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-ALPINE317-MUSL-8720633 - https://snyk.io/vuln/SNYK-ALPINE317-MUSL-8720633 - https://snyk.io/vuln/SNYK-ALPINE317-OPENSSL-8235199 - https://snyk.io/vuln/SNYK-ALPINE317-OPENSSL-8235199
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @tpsaint, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to improve the security posture of the project by updating the Docker base image. The upgrade from Alpine Linux version 3.17 to 3.23.2 resolves several critical and minor vulnerabilities, thereby reducing potential security risks within the containerized application environment. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request from Snyk aims to upgrade the alpine base image to fix security vulnerabilities. While the intention is good, the implementation has two critical flaws:
- The change is made directly to an auto-generated Dockerfile (
3.9/alpine3.17/Dockerfile), which is explicitly discouraged by a comment header in the file. This means the fix will be overwritten the next time the generation script (apply-templates.sh) is run. The correct approach is to modify the source files (likelyversions.json) and regenerate all Dockerfiles. - The fix is incomplete. It only updates the Dockerfile for Python 3.9, while several other Python versions in this repository (
3.8,3.10,3.11,3.12,3.13-rc) also use the vulnerablealpine:3.17base image and are left unpatched.
Due to these critical issues, this PR should not be merged in its current state. The changes need to be applied to the template generation source to ensure the fix is correct, complete, and persistent.
| # | ||
|
|
||
| FROM alpine:3.17 | ||
| FROM alpine:3.23.2 |
There was a problem hiding this comment.
This change is applied to a generated file, which is incorrect. The header of this file explicitly states: 'PLEASE DO NOT EDIT IT DIRECTLY.'
Any changes made here will be lost when the apply-templates.sh script is run again. The proper way to apply this update is to modify the source configuration, likely versions.json, to change the alpine3.17 variant to the new version, and then regenerate all affected Dockerfiles.
Furthermore, this fix is incomplete as it only targets the Python 3.9 image. Other images for Python versions 3.8, 3.10, 3.11, 3.12, and 3.13-rc still use the vulnerable alpine:3.17 base image and must also be updated.
Snyk has created this PR to fix 2 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):
3.9/alpine3.17/DockerfileWe recommend upgrading to
alpine:3.23.2, as this image has only 0 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.Vulnerabilities that will be fixed with an upgrade:
SNYK-ALPINE317-MUSL-8720633
SNYK-ALPINE317-MUSL-8720633
SNYK-ALPINE317-OPENSSL-8235199
SNYK-ALPINE317-OPENSSL-8235199
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.