Skip to content

fix "TypeError: main.startsWith is not a function" error#75

Merged
mvayngrib merged 4 commits intotradle:masterfrom
badver:fix_type_error_main.startsWith_is_not_a_function
Dec 18, 2018
Merged

fix "TypeError: main.startsWith is not a function" error#75
mvayngrib merged 4 commits intotradle:masterfrom
badver:fix_type_error_main.startsWith_is_not_a_function

Conversation

@badver
Copy link
Copy Markdown
Contributor

@badver badver commented Dec 18, 2018

fix "TypeError: main.startsWith is not a function" error if "main" in't a string

Fixes #74

@mvayngrib
Copy link
Copy Markdown
Member

@badver thanks for the PR!

I'm guessing the fix is one or two lines, but the diff has nearly every line changed :(

Can you refactor so that only the fix-related lines are changed?

@badver
Copy link
Copy Markdown
Contributor Author

badver commented Dec 18, 2018

Sure, sorry for this. VSCode reformat code on save :(

@mvayngrib mvayngrib merged commit f50ba67 into tradle:master Dec 18, 2018
@mvayngrib
Copy link
Copy Markdown
Member

@badver thanks!

mvayngrib pushed a commit that referenced this pull request Dec 25, 2018
* fix "TypeError: main.startsWith is not a function" error if "main" isn't a string

Fixes #74
mvayngrib added a commit that referenced this pull request Apr 7, 2019
* master:
  docs: --yarn option
  docs: update repo links, install instructions in README
  chore: update git repo url in package.json
  10.0.1
  fix "TypeError: main.startsWith is not a function" error (#75)
  10.0.0
  refactor to use @tradle/react-native-http
  9.0.0
  Remove dynamic require, and explain in README
  8.3.0
  Add a comment explaining the need for dynamic require
  Conditionally require crypto module in shim.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: main.startsWith is not a function

2 participants