Skip to content

improve index query performance - #1276

Merged
Yrp merged 1 commit into
compaarefrom
improve_index
Aug 9, 2018
Merged

Yrp merged 1 commit into
compaarefrom
improve_index

Conversation

@Yrp

@Yrp Yrp commented Aug 9, 2018

Copy link
Copy Markdown
Contributor

What does this PR do?

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@hongz hongz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 2
Code Smell Code Smells: 0

See all issues in SonarCloud

public static Attribute<WrappedByteArray, String> OWNERS;
public static Attribute<WrappedByteArray, String> TOS;
public static Attribute<WrappedByteArray, Long> TIMESTAMP;
public static Attribute<WrappedByteArray, Long> INDEX_CREATE_TIMESTAMP;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vulnerability Vulnerability: Make this "public static INDEX_CREATE_TIMESTAMP" field final (squid:S1444)

See it in SonarCloud

public static Attribute<WrappedByteArray, String> OWNERS;
public static Attribute<WrappedByteArray, String> TOS;
public static Attribute<WrappedByteArray, Long> TIMESTAMP;
public static Attribute<WrappedByteArray, Long> INDEX_CREATE_TIMESTAMP;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vulnerability Vulnerability: Make INDEX_CREATE_TIMESTAMP a static final constant or non-public and provide accessors if needed. (squid:ClassVariableVisibilityCheck)

See it in SonarCloud

@Yrp
Yrp merged commit 35b822b into compaare Aug 9, 2018
@shydesky
shydesky deleted the improve_index branch November 13, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants