Skip to content

mdf some net unit test - #1848

Merged
shydesky merged 1 commit into
masterfrom
mdfunittest
Dec 17, 2018
Merged

shydesky merged 1 commit into
masterfrom
mdfunittest

Conversation

@shydesky

Copy link
Copy Markdown
Contributor

What does this PR do?
modify some net unit test
Why are these changes required?
some logic about peer connect other peer changed, so the unit test should be optimised
This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@shydesky
shydesky requested review from lvs007 and wubin12 December 13, 2018 04:32
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1848 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1848   +/-   ##
=========================================
  Coverage     45.61%   45.61%           
  Complexity     3792     3792           
=========================================
  Files           461      461           
  Lines         26816    26816           
  Branches       2723     2723           
=========================================
  Hits          12233    12233           
  Misses        13522    13522           
  Partials       1061     1061

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d736c3f...b2126ca. Read the comment docs.

@shydesky
shydesky requested review from jiangyy0824 and removed request for lvs007 and wubin12 December 14, 2018 15:02

@jiangyy0824 jiangyy0824 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review ok

@shydesky
shydesky merged commit eed364d into master Dec 17, 2018
@shydesky
shydesky deleted the mdfunittest branch January 4, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants