Skip to content

Bugfix/vm commit null value for issue 1945 - #1929

Merged
huzhenyuan merged 12 commits into
developfrom
bugfix/vm_commit_null_value
Jan 18, 2019
Merged

huzhenyuan merged 12 commits into
developfrom
bugfix/vm_commit_null_value

Conversation

@yinshucheng

@yinshucheng yinshucheng commented Jan 11, 2019 •

Copy link
Copy Markdown
Contributor

What does this PR do?
Avoid unknown exception in vm because of commiting null value.

Why are these changes required?

  1. Add necessary log
  2. Handle if create contract failed

This PR has been tested by:

  • Unit Tests : CreateContractSuicideTest
  • Manual Testing

Follow up

Extra details

@codecov-io

codecov-io commented Jan 11, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #1929 into develop will increase coverage by 0.11%.
The diff coverage is 57.14%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1929      +/-   ##
=============================================
+ Coverage      45.61%   45.73%   +0.11%     
- Complexity      4104     4193      +89     
=============================================
  Files            494      495       +1     
  Lines          28725    29155     +430     
  Branches        2987     3106     +119     
=============================================
+ Hits           13104    13335     +231     
- Misses         14473    14669     +196     
- Partials        1148     1151       +3
Impacted Files Coverage Δ Complexity Δ
...main/java/org/tron/common/runtime/RuntimeImpl.java 63.52% <0%> (+0.24%) 54 <0> (+1) ⬆️
src/main/java/org/tron/common/runtime/vm/VM.java 62.68% <100%> (+0.32%) 100 <0> (+1) ⬆️
...c/main/java/org/tron/core/db/TransactionTrace.java 53.28% <100%> (ø) 18 <0> (ø) ⬇️
src/main/java/org/tron/common/storage/Value.java 21.73% <50%> (+2.04%) 7 <0> (ø) ⬇️
...va/org/tron/common/runtime/vm/LogEventWrapper.java 73.52% <0%> (-26.48%) 19% <0%> (+10%)
.../org/tron/common/logsfilter/EventPluginConfig.java 94.11% <0%> (-5.89%) 7% <0%> (ø)
...ogsfilter/capsule/ContractEventTriggerCapsule.java 53.12% <0%> (-2.44%) 2% <0%> (ø)
src/main/java/org/tron/program/FullNode.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
src/main/java/org/tron/program/SolidityNode.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...gsfilter/capsule/TransactionLogTriggerCapsule.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e35c0fc...6f7887c. Read the comment docs.

@huzhenyuan

Copy link
Copy Markdown
Contributor

#1945

@huzhenyuan huzhenyuan changed the title Bugfix/vm commit null value Bugfix/vm commit null value for issue 1945 Jan 18, 2019
@huzhenyuan
huzhenyuan merged commit 252617f into develop Jan 18, 2019
@shydesky
shydesky deleted the bugfix/vm_commit_null_value branch November 13, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants