WIP: Some DF fixes#8718
Draft
AdamGS wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 1.005x ➖ How to read Verdict and Engines
datafusion / vortex-file-compressed (1.005x ➖, 0↑ 0↓)
No file size changes detected. |
Merging this PR will not alter performance
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing 
Footnotes
|
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.040x ➖, 0↑ 1↓)
datafusion / parquet (0.983x ➖, 1↑ 0↓)
datafusion / arrow (0.950x ➖, 6↑ 0↓)
duckdb / vortex-file-compressed (1.057x ➖, 0↑ 1↓)
duckdb / parquet (1.026x ➖, 0↑ 0↓)
File Size Changes (17 files changed, -44.6% overall, 4↑ 13↓)
Totals:
|
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.972x ➖, 0↑ 0↓)
datafusion / parquet (0.979x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.978x ➖, 0↑ 0↓)
duckdb / parquet (0.990x ➖, 0↑ 0↓)
File Size Changes (3 files changed, -46.4% overall, 0↑ 3↓)
Totals:
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.969x ➖, 1↑ 1↓)
datafusion / parquet (0.979x ➖, 4↑ 0↓)
duckdb / vortex-file-compressed (0.971x ➖, 6↑ 0↓)
duckdb / parquet (0.983x ➖, 1↑ 0↓)
File Size Changes (30 files changed, -43.4% overall, 2↑ 28↓)
Totals:
|
Contributor
Benchmarks: Clickbench Sorted on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.871x ✅, 8↑ 1↓)
datafusion / parquet (0.933x ➖, 3↑ 0↓)
duckdb / vortex-file-compressed (0.848x ✅, 5↑ 0↓)
duckdb / parquet (0.971x ➖, 0↑ 0↓)
File Size Changes (201 files changed, -42.6% overall, 47↑ 154↓)
Totals:
|
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.152x ➖, 0↑ 3↓)
datafusion / parquet (1.208x ➖, 0↑ 2↓)
duckdb / vortex-file-compressed (0.980x ➖, 0↑ 0↓)
duckdb / parquet (1.009x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) How to read Verdict and Engines
duckdb / vortex-file-compressed (1.012x ➖, 0↑ 0↓)
duckdb / parquet (1.027x ➖, 0↑ 0↓)
File Size Changes (3 files changed, -32.3% overall, 0↑ 3↓)
Totals:
|
Contributor
Benchmarks: Clickbench on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.982x ➖, 0↑ 1↓)
datafusion / parquet (0.992x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.977x ➖, 2↑ 0↓)
duckdb / parquet (0.990x ➖, 1↑ 0↓)
File Size Changes (201 files changed, -39.1% overall, 56↑ 145↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.077x ➖, 0↑ 6↓)
datafusion / parquet (1.018x ➖, 0↑ 4↓)
datafusion / arrow (1.096x ➖, 0↑ 7↓)
duckdb / vortex-file-compressed (1.055x ➖, 0↑ 5↓)
duckdb / parquet (1.039x ➖, 0↑ 5↓)
File Size Changes (47 files changed, -44.4% overall, 18↑ 29↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.251x ➖, 0↑ 7↓)
datafusion / parquet (1.020x ➖, 3↑ 7↓)
duckdb / vortex-file-compressed (1.098x ➖, 0↑ 1↓)
duckdb / parquet (1.102x ➖, 0↑ 0↓)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
General improvements of the
FileSource-based Apache DataFusion integration.What changes are included in this PR?
ParquetSourceprovides.batch_sizefrom the source, by default DataFusion splits the data coming out ofDataScanExecnodes.What APIs are changed? Are there any user-facing changes?
More metrics will be reported in DF, and batch size needs to be done through the
DataSourceExecandFileScanConfiglevel.