Skip to content

docs: promote Warp Factories navigation (Phase 2) - #786

Open
rachaelrenk wants to merge 4 commits into
mainfrom
rrenk/factories-launch-phases-2-4
Open

rachaelrenk wants to merge 4 commits into
mainfrom
rrenk/factories-launch-phases-2-4

Conversation

@rachaelrenk

@rachaelrenk rachaelrenk commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Promotes Warp Factories to the first product tab, makes the root product overview the Factory-tab destination, and gives Warp Terminal its own overview page. This PR now contains only Phase 2 navigation work on main, independent of the later migration and naming phases.

Changes

  • Moves Factories to the first sidebar tab and Automation Platform immediately after it.
  • Makes / the Factory-tab destination and adds Warp products as the first entry in Factories Overview. The existing root product overview is unchanged.
  • Adds /terminal/ as the Terminal overview and restructures Terminal navigation into Overview followed by Get started.
  • Preserves the Automation Platform's standalone overview and Cloud agents group.
  • Narrows sidebar labels to strings before looking up topic order, fixing the two TypeScript errors caused by the plugin's translated-label union type.

Related issues

Content design plan

Audience and JTBD: A developer choosing where to start in the docs who needs the product tabs to match Warp's launch product hierarchy.

Problem: The Terminal tab currently owns the root product overview, while Warp Factories remains visually secondary.

Goals: Put Factories first, keep Warp products discoverable at /, and give Terminal a clear product overview plus a separate onboarding path.

Content type: Conceptual navigation and overview update.

High-impact scenarios: Covers a new visitor entering the Factory tab, a Terminal user finding terminal documentation, and a cloud-agent user retaining the Automation Platform path.

Staging and handoff

  • Base - main. Rebasing onto current origin/main completed without conflicts on October 8.
  • Scope - Replayed only the launch-specific commits above the Phase 1 branch. The resulting diff touches two files: src/sidebar.ts and src/content/docs/terminal/index.mdx.
  • Branch - rrenk/factories-launch-phases-2-4; the name is retained to preserve the existing PR, but this PR is now Phase 2 only.
  • Workspace - /Users/rachaelrenk/Documents/Warp/docs-factories-launch-phases-2-4.
  • Recovery - Original local history is preserved on backup/factories-launch-pre-rebase-20261008.

Validation

Local validation on October 8:

  • npm ci - completed with lockfile-pinned dependencies.
  • npm run typecheck - passed with 0 errors and 7 hints.
  • npm run build - passed.
  • npm run test:homepage-json-ld - passed.
  • python3 .agents/skills/check_for_broken_links/check_links.py --internal-only - passed with 0 broken links across 4,366 internal links.
  • python3 scripts/test_check_redirects.py - passed all 3 tests.
  • python3 .agents/skills/style_lint/style_lint.py --changed - passed with two non-blocking product-casing warnings. "Warp Terminal" is retained in the page title and product-comparison link description to distinguish the terminal product.
  • python3 .agents/skills/validate_ui_refs/validate_ui_refs.py --changed --require-provenance - passed with 0 issues.
  • git diff --check - passed.

Trunk is not installed locally. Node v25 is outside the project's supported runtime range; GitHub CI uses Node 22. Dependency installation also reported existing audit findings and a starlight-llms-txt patch-version warning; this PR does not change dependencies.

Follow-ups

These are outside this PR and do not hold Phase 2 for implementation:

Unverified claims

None. The new Terminal overview summarizes existing documented capabilities; this PR adds no new product behavior or availability claims.

Documentation risk

Risk: engineering-review-required
Rationale: Changes published navigation order and the root and Terminal documentation entry points.
Source files consulted: GROW-6142, src/sidebar.ts, src/content/docs/index.mdx, src/content/docs/factories/index.mdx, and existing Terminal documentation pages.
Requested engineering reviewers: none
Engineering review status: pending
Docs override: none

Agent context

Conversation

Co-Authored-By: Warp agent@warp.dev

@cla-bot cla-bot Bot added the cla-signed label Sep 22, 2026
@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 9, 2026 1:43pm UTC

Request Review

@rachaelrenk rachaelrenk added the warpy-factory Opened by the Warp factory agents label Sep 22, 2026
@rachaelrenk
rachaelrenk force-pushed the rrenk/factories-launch-phases-2-4 branch from 49e157b to 0a94f17 Compare September 23, 2026 13:53
Base automatically changed from rrenk/grow-6127-factories-ga to main October 6, 2026 05:43
rachaelrenk and others added 3 commits October 8, 2026 12:33
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
@rachaelrenk
rachaelrenk force-pushed the rrenk/factories-launch-phases-2-4 branch from 0a94f17 to 7c8bc5f Compare October 8, 2026 18:42
@rachaelrenk
rachaelrenk marked this pull request as ready for review October 8, 2026 18:43
@warp-for-oss

warp-for-oss Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

@rachaelrenk

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@warp-for-oss warp-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR stages the Phase 2 documentation navigation update by adding a Terminal overview page, moving the Terminal tab to /terminal/, making the Factories tab point at the root product overview, and sorting the top-level sidebar topics into the launch order.

Concerns

  • No blocking general, security, or spec-alignment concerns found in the attached diff. spec_context.md reports that no approved or repository spec context was found, so there was no implementation spec to compare against.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@rachaelrenk rachaelrenk changed the title docs: stage Factories launch phases docs: promote Warp Factories navigation (Phase 2) Oct 8, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

The independent agent completed its review for this commit.

Findings

  • src/sidebar.ts:391 — [IMPORTANT] Making / the Factories topic leaves src/components/CustomSidebar.astro (breadcrumbFromUrl: if (segments.length === 0) return TOPIC_LABELS.terminal;) labeling the root page's search result "Terminal", although the root now sits under the Factories tab. Requested change: update that fallback so the root breadcrumb matches the new navigation (for example TOPIC_LABELS.factories or a neutral products label) and update any adjacent comment.
  • src/sidebar.ts:933 — [SUGGESTION] Reordering topics with a post-hoc sidebarTopics.sort(...) and a phaseTwoTopicOrder map makes the array literal disagree with the rendered order, silently sorts unlisted topics last, and bakes a launch-phase name into the source. Requested change: move the Factories and Automation Platform entries to the top of the sidebarTopics literal and delete the Map and sort block, or rename it to topicOrder and add a comment explaining why the literal isn't reordered.
  • src/content/docs/terminal/index.mdx:10 — [SUGGESTION] The opening paragraph ("combines a terminal, editor, and agent workspace in one application... without leaving your local development environment") reads as a product pitch, against AGENTS.md Voice & tone. Requested change: replace it with one or two plain declarative sentences stating what Warp Terminal does, and cut the "without leaving..." tail.
  • src/content/docs/terminal/index.mdx:14 — [SUGGESTION] Each bullet on lines 14-18 bolds a feature name and then repeats it in a trailing "See same name" link, and line 14 says "Terminal Blocks" while the other links use lowercase names. Requested change: link the bold term itself (for example **[Blocks](/terminal/blocks/)**), drop the "See ..." tails, and make link text consistent.
  • src/content/docs/terminal/index.mdx:20 — [SUGGESTION] The "Get started" H2 holds one sentence linking to the quickstart, and the [Agents](/agents/) Related pages link on line 28 has generic text. Requested change: fold the quickstart link into the intro or the first Related pages bullet and remove the separate H2, and rename the Agents link to say what the reader finds, such as "Agents in Warp".

Verdict

Request changes

This branch was successfully deployed

1 active deployment
Preview — 1c66fb04 Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed warpy-factory Opened by the Warp factory agents

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants