Agent Mode: model who drives a conversation as a ConversationDriver enum

[kevinyang372]

Description

Prep PR for the ACP harness stack (inserted between 2/4 and 3/4), from the design discussion on #16331. No behavior change.

AIConversation carried three overlapping booleans that each answered part of "who owns this turn": is_viewing_shared_session (~25 call sites conflating "not owned here" with "inputs arrive via the stream"), is_cli_agent_transcript, and is_remote_child. The next PR needs a fourth mode (an external harness that authors the stream but whose lifecycle this client does not own), and bolting on another boolean would mean auditing every site again.

What:

• ai/agent/conversation_driver.rs: enum ConversationDriver { Native, SharedSessionViewer, CliAgentTranscript, RemoteChild } with exhaustive-match predicates that call sites can ask instead of "is this a viewer?": owns_turn_lifecycle, executes_tool_calls_locally, reconstructs_inputs_from_messages, reports_task_status, is_read_only_ui, is_persisted_locally.
• AIConversation stores a single driver (plus driver() / set_driver()); the three booleans and their setters remain as thin wrappers whose docs point at the predicate to migrate to, so no call site outside conversation.rs changes. Inside conversation.rs the three input-reconstruction sites and the persistence guard move to the predicates they actually mean.
• The parent/child relationship (parent_conversation_id) is an orthogonal axis and is left alone.

Audit: no production or test path ever sets two of the old booleans on one conversation (is_cli_agent_transcript only via start_new_conversation from mutually exclusive AgentViewEntryOrigins; mark_as_remote_child only on a fresh child; set_is_viewing_shared_session(true) only on cloud-restored/forked conversations with is_remote_child hard-coded false), so a flat enum loses nothing. set_is_viewing_shared_session(false) only demotes a SharedSessionViewer back to Native, matching the old independent-bool semantics under that invariant.

Deliberately not migrated (candidates for a follow-up, each a one-line change once the enum exists): local_agent_task_sync_model.rs (reports_task_status), agent_input_footer (is_read_only_ui), and the viewer-only timing / exchange-move / temp-dir-cleanup sites in conversation.rs.

Linked Issue

• The linked issue is labeled ready-to-spec or ready-to-implement.
• Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

New conversation_driver_tests.rs (per-variant predicate table) and conversation_tests.rs cases for constructor → driver mapping and wrapper/setter semantics. Ran the conversation, blocklist controller, history model, shared session, pane group, orchestration, task sync, and agent-view suites (~1,250 tests) — all pass. cargo clippy -D warnings and ./script/format clean.

• I have manually tested my changes locally with ./script/run

Agent Mode

• Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Co-Authored-By: Warp agent@warp.dev

[kevinyang372]

• Agent driver: ACP client, MAA mapping, and the ACP harness runner #16332 : 2 dependent PRs (#16387 , #16393 )
• Agent Mode: let an external harness drive a native conversation turn #16331
• Agent Mode: model who drives a conversation as a ConversationDriver enum #16355 👈 (View in Graphite)
• Agent driver: run an ACP harness inside the terminal session over a socket bridge #16330
• Agent driver: accept an ACP transport mode for third-party harnesses #16329
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[warp-for-oss]

@kevinyang372

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[warp-for-oss]

Overview

This PR replaces the overlapping AIConversation ownership booleans with a ConversationDriver enum, keeps compatibility wrappers for existing call sites, and adds focused unit coverage for driver predicates, constructor mapping, restore mapping, and wrapper semantics.

Concerns

• No blocking concerns found. I did not find material spec drift; the provided spec context contains no approved repository spec. The security pass did not identify new input, auth, secrets, logging, command execution, or data-handling risks.
• Comment audit: the added/changed doc comments on ConversationDriver and the legacy wrapper methods document current API semantics and migration guidance without narrating implementation internals; the new test comment explains the compatibility invariant being asserted.
• Test audit: the new tests cover the per-variant predicate table and the legacy constructor/wrapper behavior affected by the refactor.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[warp-factories]

@kevinyang372 Warp CI failed on this PR. May the windows runner test factory diagnose it, commit fixes, and push to this same branch? Explicit consent also opts this PR into automatic handling of future CI failures; we will not open a replacement PR or merge.

Please reply to this request with an explicit yes or no, mentioning @warp and “windows runner test”.

Responding as windows runner test: Open session · View in factory

[bnavetta]

Nice!