Mchinta/renderhelm - #321
Merged
Merged
Conversation
Manasa Chinta (manasachi)
force-pushed
the
mchinta/renderhelm
branch
2 times, most recently
from
June 26, 2024 15:21
ce19c0e to
dd0cc0d
Compare
Manasa Chinta (manasachi)
requested review from
Nick Keller (NickKeller),
David Gamero (davidgamero) and
Tommy Barnes (tbarnes94)
June 26, 2024 15:45
Tommy Barnes (tbarnes94)
approved these changes
Jun 26, 2024
Tommy Barnes (tbarnes94)
left a comment
Contributor
There was a problem hiding this comment.
LGTM - great job!
Nick Keller (NickKeller)
approved these changes
Jun 27, 2024
David Gamero (davidgamero)
approved these changes
Jun 27, 2024
David Gamero (davidgamero)
left a comment
Collaborator
There was a problem hiding this comment.
lgtm
David Gamero (davidgamero)
approved these changes
Jun 27, 2024
Manasa Chinta (manasachi)
enabled auto-merge (squash)
June 27, 2024 19:00
Manasa Chinta (manasachi)
force-pushed
the
mchinta/renderhelm
branch
2 times, most recently
from
June 27, 2024 19:21
bf166f0 to
54f5678
Compare
Manasa Chinta (manasachi)
disabled auto-merge
June 27, 2024 19:31
Manasa Chinta (manasachi)
enabled auto-merge (squash)
June 27, 2024 19:31
Manasa Chinta (manasachi)
disabled auto-merge
June 27, 2024 19:32
Signed-off-by: manasachi <manasachinta7@gmail.com>
Signed-off-by: manasachi <manasachinta7@gmail.com>
Signed-off-by: manasachi <manasachinta7@gmail.com>
Manasa Chinta (manasachi)
force-pushed
the
mchinta/renderhelm
branch
from
June 27, 2024 19:50
54f5678 to
f8c644c
Compare
Manasa Chinta (manasachi)
enabled auto-merge (squash)
June 27, 2024 19:53
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding a render helm function which writes rendered manifests from helm chart's templates.
Sub-charts are also supported. Given a helm chart with multiple sub-charts, all templates associated with the main chart and subcharts will be rendered and written. Given a path to a sub-chart, within a helm chart, the sub-chart will be handled as an independent chart.
Fixes # (issue)
Feature # Support in draft validate for helm charts
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).
Checklist: