Skip to content

Mchinta/renderhelm - #321

Merged
Manasa Chinta (manasachi) merged 22 commits into
mainfrom
mchinta/renderhelm
Jun 27, 2024
Merged

Manasa Chinta (manasachi) merged 22 commits into
mainfrom
mchinta/renderhelm

Conversation

@manasachi

@manasachi Manasa Chinta (manasachi) commented Jun 21, 2024 •

Copy link
Copy Markdown
Contributor

Description

Adding a render helm function which writes rendered manifests from helm chart's templates.

Sub-charts are also supported. Given a helm chart with multiple sub-charts, all templates associated with the main chart and subcharts will be rendered and written. Given a path to a sub-chart, within a helm chart, the sub-chart will be handled as an independent chart.

Fixes # (issue)
Feature # Support in draft validate for helm charts

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Test A: Unit testing
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Comment thread pkg/safeguards/preprocessing_helpers.go Outdated
Comment thread pkg/safeguards/preprocessing_helpers.go
Comment thread pkg/safeguards/preprocessing_helpers.go Outdated

@tbarnes94 Tommy Barnes (tbarnes94) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - great job!

Comment thread pkg/safeguards/preprocessing_helpers.go

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@manasachi
Manasa Chinta (manasachi) enabled auto-merge (squash) June 27, 2024 19:00
@manasachi
Manasa Chinta (manasachi) force-pushed the mchinta/renderhelm branch 2 times, most recently from bf166f0 to 54f5678 Compare June 27, 2024 19:21
@manasachi
Manasa Chinta (manasachi) enabled auto-merge (squash) June 27, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants