Skip to content

Validate with Helm and Kustomize Support - #392

Merged
Manasa Chinta (manasachi) merged 7 commits into
mainfrom
staging-safeguards
Nov 13, 2024
Merged

Validate with Helm and Kustomize Support#392
Manasa Chinta (manasachi) merged 7 commits into
mainfrom
staging-safeguards

Conversation

@manasachi

@manasachi Manasa Chinta (manasachi) commented Oct 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Merging helm and kustomize support for draft validate.
Draft validate will validate manifests given a path to a helm chart, Kustomize dir, a directory of .yaml files, or a single yaml file.

Helm specifically requires --releaseName or -n and --releaseNamespace or -e flags. Otherwise, it uses the directory name as the default name.

Fixes # (issue)
Feature # (details)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

How Has This Been Tested?

Provide instructions so we can reproduce, and list any relevant details for your test configuration. Please mention if this is a breaking change which will impact consuming tool(s).

  • Unit Test:
  • E2E Test:
  • Other Test:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@manasachi
Adding GetManifestFiles() and refactoring (#346)
7125fbf 
Signed-off-by: Manasa Chinta <manasachinta7@gmail.com>
@tbarnes94 @manasachi @bfoley13
Adding CLI flags for user defined Helm release name and release names…
39bc803 
…pace for rendering helm projects (#352)

Co-authored-by: manasachi <144361666+manasachi@users.noreply.github.com>
Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
Signed-off-by: Manasa Chinta <manasachinta7@gmail.com>
@manasachi
Removing Manifest Path property, replacing with []byte content (#355)
2394a6f 
Signed-off-by: Manasa Chinta <manasachinta7@gmail.com>
@manasachi
Cleanup for kustomize/helm feature (#357)
f8162e2 
Signed-off-by: Manasa Chinta <manasachinta7@gmail.com>
@manasachi Manasa Chinta (manasachi) changed the title Staging safeguards Validate with Helm and Kustomize Support Oct 7, 2024
tbarnes94
Tommy Barnes (tbarnes94) approved these changes Oct 7, 2024
View reviewed changes

@tbarnes94 Tommy Barnes (tbarnes94) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a nit comment, otherwise LGTM! Good job!

Comment thread pkg/safeguards/preprocessing/preprocessing.go
davidgamero
David Gamero (davidgamero) approved these changes Nov 13, 2024
View reviewed changes

@davidgamero David Gamero (davidgamero) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm love to see support for the rendered chart types

@manasachi
Manasa Chinta (manasachi) deleted the staging-safeguards branch November 13, 2024 20:54
@bfoley13 Brandon Foley (bfoley13) mentioned this pull request Dec 4, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Dec 5, 2024
Merged
Audra Stump (audrastump) pushed a commit to audrastump/draft that referenced this pull request Dec 13, 2024
@manasachi @tbarnes94
@bfoley13 @davidgamero @audrastump
Validate with Helm and Kustomize Support (Azure#392)
aee2be7 
Signed-off-by: Manasa Chinta <manasachinta7@gmail.com>
Co-authored-by: Tommy Barnes <thomas.jonathan.barnes@gmail.com>
Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
Co-authored-by: David Gamero <david340804@gmail.com>
Audra Stump (audrastump) pushed a commit to audrastump/draft that referenced this pull request Dec 16, 2024
@manasachi @tbarnes94
@bfoley13 @davidgamero @audrastump
Validate with Helm and Kustomize Support (Azure#392)
bba0093 
Signed-off-by: Manasa Chinta <manasachinta7@gmail.com>
Co-authored-by: Tommy Barnes <thomas.jonathan.barnes@gmail.com>
Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
Co-authored-by: David Gamero <david340804@gmail.com>
Audra Stump (audrastump) pushed a commit to audrastump/draft that referenced this pull request Dec 19, 2024
@manasachi @tbarnes94
@bfoley13 @davidgamero @audrastump
Validate with Helm and Kustomize Support (Azure#392)
d2ef04d 
Signed-off-by: Manasa Chinta <manasachinta7@gmail.com>
Co-authored-by: Tommy Barnes <thomas.jonathan.barnes@gmail.com>
Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
Co-authored-by: David Gamero <david340804@gmail.com>
Audra Stump (audrastump) pushed a commit to audrastump/draft that referenced this pull request Jan 2, 2025
@manasachi @tbarnes94
@bfoley13 @davidgamero @audrastump
Validate with Helm and Kustomize Support (Azure#392)
2e7ace3 
Signed-off-by: Manasa Chinta <manasachinta7@gmail.com>
Co-authored-by: Tommy Barnes <thomas.jonathan.barnes@gmail.com>
Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
Co-authored-by: David Gamero <david340804@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidgamero David Gamero (davidgamero) davidgamero approved these changes
@NickKeller Nick Keller (NickKeller) NickKeller approved these changes
+1 more reviewer
@tbarnes94 Tommy Barnes (tbarnes94) tbarnes94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@manasachi @davidgamero @NickKeller @tbarnes94