[dayfine]

Moves SV AutoStory's repeated start/end dropdown and story-index code into two shared helpers that other games' AutoStory can reuse.

• make_story_select_database() builds a start/end dropdown from a slice of the segment or checkpoint list, slugged by the index in the whole list. It replaces six hand-built databases.
• story_index() does the tutorial/main-story offset once, instead of in six helpers and two descriptions.
• Both are in Pokemon/AutoStory/Pokemon_AutoStorySelect.h, with their tests beside it. No behaviour change.

Testing

• New unit tests Pokemon::AutoStoryIndex and Pokemon::AutoStorySelectDatabase; fork CI passed on Mac, Windows Clang and Ubuntu.
• Not run on a Switch, since nothing changes in behaviour.

🤖 Generated with Claude Code

[Mysticial]

@jw098 will need to look at this one since I assume the expectation is that SV AutoStory would get its options refactored to use this.

[pa-devbot]

AI review: Clean, behavior-preserving refactor. Verified on this branch: it builds and the full command-line suite is green (20,333 passed / 0 failed / 3 skipped), including the 6 new tests (Pokemon::AutoStoryIndex, Pokemon::AutoStorySelectDatabase).

What's good

• make_story_select_database() slugs by whole-list index and reads name() off the entry, matching the old std::to_string(index_num) builders. The i < list.size() clamp is a small robustness win over the old all_segments[i] indexing. Templating on Entry (any type with name()) is what lets one helper serve both segments and checkpoints.
• story_index() collapses the first_main_story_index + idx offset into one place; all four get_*_index() now route through it, and the two checkpoint descriptions now call their getters. Equivalent to the original if/else for both TUTORIAL and MAIN_STORY (only two enum values, default TUTORIAL).
• Tests hit the interesting cases: whole-list slugging, tutorial pass-through, main-story offset, and the end-past-list clamp.

One gap in the SV refactor — the tutorial/main-story offset is still inlined in the two segment description functions, which were left behind while the sibling checkpoint descriptions were moved to call their getters:

• SerialPrograms/Source/VideoGames/PokemonSV/Programs/AutoStory/PokemonSV_AutoStory.cpp:1030 start_segment_description()
• .../PokemonSV_AutoStory.cpp:1040 end_segment_description()

For symmetry with start_checkpoint_description()/end_checkpoint_description() (which now call get_start_checkpoint_index()/get_end_checkpoint_index()), these could just be:

std::string AutoStory::start_segment_description(){
    return "    " + ALL_AUTO_STORY_SEGMENT_LIST()[get_start_segment_index()]->start_text();
}
std::string AutoStory::end_segment_description(){
    return "    " + ALL_AUTO_STORY_SEGMENT_LIST()[get_end_segment_index()]->end_text();
}

That removes the last two inline copies of the offset and makes story_index() the single source of truth. Behavior is unchanged.

(Aside: no other game has an AutoStory program yet, so SV is the only consumer today — good that the helpers already live in Pokemon/AutoStory/ in the Pokemon namespace, ready to be reused the moment another game ships one.)

[jw098]

Overall, looks fine to me. My only comment is that we currently assume only 2 main sections: Tutorial + Main. But if this changes in the future, we'll need to refactor it to handle N sections.

[dayfine]

Overall, looks fine to me. My only comment is that we currently assume only 2 main sections: Tutorial + Main. But if this changes in the future, we'll need to refactor it to handle N sections.

added a NOTE -- might tackle that as I do PostGame (Seveii islands) for FRLG

[jw098]

You only need separate story sections if the automation needs to take a break. e.g. between the SV tutorial and main story, the user had to manually level up the leak Pokemon. If there are no breaks required, you don't need a separate story section.

[dayfine]

Makes sense — sections are break points. Updated the NOTE: postgame/DLC append to the last section unless they need their own break.