Repository navigation
Conversation
- YZ jsonnets: read YZMap file names from fcl (YZMapJson, YZScaleMapJson) again; the merge of PR 905 (147c112) had hardcoded the Run 1 maps. - detsimmodules_wirecell_per_TPC_ICARUS.fcl: tuned gains (18.0839, 12.2379, 13.8819 mV/fC) and time offsets (2.53, 2.41, 2.53 us) as in detsimmodules_wirecell_ICARUS.fcl; add YZ map and lifetime DB params (DBFileName/DBTag, needed by the overlay drifter). The yz_0..3 blocks now take these values, DL/DT and lifetime from the base block instead of stale literals. - Run4 detsim fcls: set the Run 4 gain map on daq0..daq3, since the YZ sim no longer has a single daq module. - detsimmodules_wirecell_ICARUS.fcl: base config back to the non-YZ refactored jsonnet, matching its outputers (as in v10_06_00_06p03).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR collects miscellaneous fixes for
develop/v10_31_00_02.Mostly configuration changes that got mixed in the porting/merging of various PRs.