Open
Allow JavaScript property named await in async functions#22500
Conversation
Co-authored-by: hvitved <3667920+hvitved@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CodeQL parse error for property named 'await' in JavaScript
Allow JavaScript property named await in async functions
Sep 3, 2026
hvitved
marked this pull request as ready for review
September 3, 2026 18:58
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The regression query cannot detect tolerated parse errors, and the changed yield behavior is untested.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates JavaScript parsing to allow contextual keywords as property names inside async/generator functions.
Changes:
- Restricts
await/yielderrors to non-liberal identifier parsing. - Adds regression coverage for
.awaitproperty access.
File summaries
| File | Description |
|---|---|
javascript/extractor/src/com/semmle/jcorn/Parser.java |
Adjusts contextual identifier validation. |
javascript/ql/test/library-tests/AwaitPropertyName/tst.js |
Adds the .await fixture. |
javascript/ql/test/library-tests/AwaitPropertyName/AwaitPropertyName.ql |
Runs the regression query. |
javascript/ql/test/library-tests/AwaitPropertyName/AwaitPropertyName.expected |
Defines empty expected output. |
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+3
to
+5
| from Expr e | ||
| where e.toString() = "this expression should not exist" | ||
| select e |
| || inputSubstring(this.start, this.end).indexOf("\\") == -1)) | ||
| this.raiseRecoverable(this.start, "The keyword '" + this.value + "' is reserved"); | ||
| if (!isPrivateField && this.inGenerator && this.value.equals("yield")) | ||
| if (!liberal && !isPrivateField && this.inGenerator && this.value.equals("yield")) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL reported a JavaScript parse error for valid property access expressions named
awaitinside async functions. This affected code such as:Parser
await/yieldidentifier restrictions for ordinary identifiers.Regression coverage
.awaitproperty access inside an async function.DCA verifies that this change resolves somes spurious syntax errors.