Skip to content

Allow JavaScript property named await in async functions #22500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow JavaScript property named await in async functions #22500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3ed273
Initial plan
Copilot Sep 3, 2026
bc58415
Allow await property names in async functions
Copilot Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions javascript/extractor/src/com/semmle/jcorn/Parser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2296,9 +2296,9 @@ protected Identifier parseIdent(boolean liberal) {
&& (this.options.ecmaVersion() >= 6
|| inputSubstring(this.start, this.end).indexOf("\\") == -1))
this.raiseRecoverable(this.start, "The keyword '" + this.value + "' is reserved");
if (!isPrivateField && this.inGenerator && this.value.equals("yield"))
if (!liberal && !isPrivateField && this.inGenerator && this.value.equals("yield"))
this.raiseRecoverable(this.start, "Can not use 'yield' as identifier inside a generator");
if (!isPrivateField && this.inAsync && this.value.equals("await"))
if (!liberal && !isPrivateField && this.inAsync && this.value.equals("await"))
this.raiseRecoverable(
this.start, "Can not use 'await' as identifier inside an async function");
name = String.valueOf(this.value);
Expand Down
Empty file added javascript/ql/test/library-tests/AwaitPropertyName/AwaitPropertyName.expected
View file
Open in desktop
Empty file.
5 changes: 5 additions & 0 deletions javascript/ql/test/library-tests/AwaitPropertyName/AwaitPropertyName.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import javascript

from Expr e
where e.toString() = "this expression should not exist"
select e
Comment on lines +3 to +5
5 changes: 5 additions & 0 deletions javascript/ql/test/library-tests/AwaitPropertyName/tst.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
const pool = { await() { return 42; } };

async function issue22499() {
return await pool.await();
}
Loading