fix(sanitize): preserve visible characters in title fields - #3215
Closed
baggiiiie wants to merge 1 commit into
Closed
fix(sanitize): preserve visible characters in title fields#3215baggiiiie wants to merge 1 commit into
baggiiiie wants to merge 1 commit into
Conversation
HTML sanitization was encoding apostrophes and other punctuation as entities in title fields. Route title-like metadata through a Title helper that restores that visible text after the strict policy runs.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Narrow fix for HTML entity leakage in title-like GitHub MCP response fields.
sanitize.Sanitizebehavior for Markdown/code-bearing bodiessanitize.Title</>escaped so nested entity payloads cannot reconstitute markupScope intentionally excluded
this PR follows #3177. Pre-existing unsanitized title-like fields such as project titles and milestones are also left unchanged.
Validation
pkg/sanitizeandpkg/githubFixes #3214