Fix HTML entities in sanitized titles - #3216
Merged
Merged
Conversation
Add an entity-aware plain-text sanitizer for titles, release names, headlines, and validation text while keeping encoded markup inert and Markdown body handling unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The sanitization changes span multiple user-facing surfaces and require final human review.
Review tier: Balanced
Findings: None
What changed in this PR
Adds entity-aware plain-text sanitization while preserving Markdown body behavior.
Changes:
- Introduces and tests
sanitize.PlainText. - Applies sanitization to titles, release names, headlines, and validation errors.
- Adds regression coverage for punctuation preservation and exact output.
| File | Description |
|---|---|
pkg/sanitize/sanitize.go |
Implements entity-aware plain-text sanitization. |
pkg/sanitize/sanitize_test.go |
Tests entities, malformed input, security, and idempotence. |
pkg/github/sanitize_coverage_test.go |
Verifies sanitization and serialized output. |
pkg/github/repositories.go |
Sanitizes blame commit headlines. |
pkg/github/minimal_types.go |
Updates title and release-name conversions. |
pkg/github/issues.go |
Updates issue and parent-title sanitization. |
pkg/github/discussions.go |
Updates discussion-title sanitization. |
pkg/errors/error.go |
Updates validation-text sanitization. |
pkg/errors/error_test.go |
Tests preserved validation-error punctuation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
script/lintscript/testFixes #3214